feat: support to build in Darwin #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Yu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 79.78% 79.81% +0.02%
==========================================
Files 33 35 +2
Lines 1583 1585 +2
==========================================
+ Hits 1263 1265 +2
Misses 204 204
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Yu-Jack , is this ready? |
@c3y1huang , I'm still checking Codecov code coverage issue. It is supposed to test |
|
@c3y1huang It's ready. |
c3y1huang
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#9487
What this PR does / why we need it:
Like longhorn/longhorn#9487 mentioned, it needs to support to build in Darwin.
Special notes for your reviewer:
I've changed syscall to unix in this PR, but I'm not sure what is actually needed in
types/namespace_darwin.goandns/joiner_darwin.go. Therefore, I left it as a no-op.Additional documentation or context
None.